From ed0bbf6069e7c3f720a7ebde5ef10e9f9af09ea2 Mon Sep 17 00:00:00 2001 From: Martijn Braam Date: Fri, 12 Mar 2021 16:52:15 +0100 Subject: [PATCH] install: don't try to embed firmware in split images (MR 2033) Split images have /dev/installp1 and /dev/installp2 but no /dev/install to place the firmware, so it will actually create that file in devfs where it might run out of space since it's only 1MB big --- pmb/install/_install.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pmb/install/_install.py b/pmb/install/_install.py index 8f92b691..53e33d98 100644 --- a/pmb/install/_install.py +++ b/pmb/install/_install.py @@ -523,7 +523,12 @@ def install_system_image(args, size_reserve, suffix, step, steps, create_home_from_skel(args) configure_apk(args) copy_ssh_keys(args) - embed_firmware(args, suffix) + + # Don't try to embed firmware on split images since there's no + # place to put it and it will end up in /dev of the chroot instead + if not split: + embed_firmware(args, suffix) + if sdcard: logging.info("Unmounting SD card (this may take a while " "to sync, please wait)")