From 66d11d6d34282a21e8bf628151794cb09bd97678 Mon Sep 17 00:00:00 2001 From: Alexey Min Date: Fri, 10 Dec 2021 20:49:33 +0300 Subject: [PATCH] pmb.helpers.ui: clarify "none" UI purpose And suggest users to use "console" UI instead. --- pmb/helpers/ui.py | 4 +++- test/test_helpers_ui.py | 7 +++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/pmb/helpers/ui.py b/pmb/helpers/ui.py index 4a355295..ceba3cad 100644 --- a/pmb/helpers/ui.py +++ b/pmb/helpers/ui.py @@ -12,7 +12,9 @@ def list(args, arch): :param arch: device architecture, for which the UIs must be available :returns: [("none", "No graphical..."), ("weston", "Wayland reference...")] """ - ret = [("none", "No graphical environment")] + ret = [("none", "Bare minimum OS image for testing and manual" + " customization. The \"console\" UI should be selected if" + " a graphical UI is not desired.")] for path in sorted(glob.glob(args.aports + "/main/postmarketos-ui-*")): apkbuild = pmb.parse.apkbuild(f"{path}/APKBUILD") ui = os.path.basename(path).split("-", 2)[2] diff --git a/test/test_helpers_ui.py b/test/test_helpers_ui.py index 137858a4..d8067836 100644 --- a/test/test_helpers_ui.py +++ b/test/test_helpers_ui.py @@ -27,6 +27,9 @@ def test_helpers_ui(args): so it must not be returned when querying the UI list for armhf. """ args.aports = f"{pmb_test.const.testdata}/helpers_ui/pmaports" func = pmb.helpers.ui.list - assert func(args, "armhf") == [("none", "No graphical environment")] - assert func(args, "x86_64") == [("none", "No graphical environment"), + none_desc = "Bare minimum OS image for testing and manual" \ + " customization. The \"console\" UI should be selected if" \ + " a graphical UI is not desired." + assert func(args, "armhf") == [("none", none_desc)] + assert func(args, "x86_64") == [("none", none_desc), ("plasma-mobile", "cool pkgdesc")]