Luca Weiss
parent
c0a8675079
commit
650ed4925e
|
|
@ -17,7 +17,7 @@ See pmbootstrap's [Development Guide](https://wiki.postmarketos.org/wiki/Develop
|
|||
* We're looking into automatizing this more, some files already get checked automatically by the [static code analysis script](test/static_code_analysis.sh).
|
||||
|
||||
### Python
|
||||
* We use the [PEP8](https://www.python.org/dev/peps/pep-0008/) standard for Python code. Don't worry, you don't need to read all that, just run the `autopep8` program on your changed code, and confirm with the [static code analyis script](test/static_code_analysis.sh) that everything is PEP8 compliant. *This script will run automatically on Travis CI when you make a Merge Request, and it must pass for your code to get accepted.*
|
||||
* We use the [PEP8](https://www.python.org/dev/peps/pep-0008/) standard for Python code. Don't worry, you don't need to read all that, just run the `autopep8` program on your changed code, and confirm with the [static code analysis script](test/static_code_analysis.sh) that everything is PEP8 compliant. *This script will run automatically on Travis CI when you make a Merge Request, and it must pass for your code to get accepted.*
|
||||
* We use the `reST` style for `docstrings` below functions (to comment what individual functions are doing, you'll see those when browsing through the code). Please stick to this format, and try to describe the important parameters and return values at least. Example from [here](https://stackoverflow.com/a/24385103):
|
||||
|
||||
```Python
|
||||
|
|
|
|||
|
|
@ -55,7 +55,7 @@ config_keys = ["ccache_size", "device", "extra_packages", "hostname", "jobs",
|
|||
|
||||
# Config file/commandline default values
|
||||
# $WORK gets replaced with the actual value for args.work (which may be
|
||||
# overriden on the commandline)
|
||||
# overridden on the commandline)
|
||||
defaults = {
|
||||
"alpine_version": "edge", # alternatively: latest-stable
|
||||
"aports": "$WORK/cache_git/pmaports",
|
||||
|
|
@ -153,7 +153,7 @@ apkindex_retention_time = 4
|
|||
# BUILD
|
||||
#
|
||||
# Officially supported host/target architectures for postmarketOS. Only
|
||||
# specify architectures supported by Alpine here. Fro cross-compiling,
|
||||
# specify architectures supported by Alpine here. For cross-compiling,
|
||||
# we need to generate the "musl-$ARCH", "binutils-$ARCH" and "gcc-$ARCH"
|
||||
# packages (use "pmbootstrap aportgen musl-armhf" etc.).
|
||||
build_device_architectures = ["armhf", "armv7", "aarch64", "x86_64", "x86"]
|
||||
|
|
|
|||
|
|
@ -46,7 +46,7 @@ def clone(args):
|
|||
" the commands it runs, you can run 'pmbootstrap log' in a"
|
||||
" second terminal.")
|
||||
logging.info("Setting up the native chroot and cloning the package build"
|
||||
" recipies (pmaports)...")
|
||||
" recipes (pmaports)...")
|
||||
|
||||
# Set up the native chroot and clone pmaports
|
||||
pmb.helpers.git.clone(args, "pmaports", False, True)
|
||||
|
|
|
|||
|
|
@ -274,7 +274,7 @@ def kconfig(args):
|
|||
if skipped:
|
||||
logging.info("NOTE: " + str(skipped) + " kernel(s) was skipped"
|
||||
" (consider 'pmbootstrap kconfig check -f')")
|
||||
logging.info("kconfig check succeded!")
|
||||
logging.info("kconfig check succeeded!")
|
||||
elif args.action_kconfig == "edit":
|
||||
pmb.build.menuconfig(args, args.package)
|
||||
|
||||
|
|
|
|||
|
|
@ -311,7 +311,7 @@ def embed_firmware(args):
|
|||
|
||||
# Perform three checks prior to writing binaries to disk: 1) that binaries
|
||||
# exist, 2) that binaries do not extend into the first partition, 3) that
|
||||
# binaries do not overlap eachother
|
||||
# binaries do not overlap each other
|
||||
binary_ranges = {}
|
||||
binary_list = []
|
||||
for binary_offset in binaries:
|
||||
|
|
|
|||
|
|
@ -459,8 +459,8 @@ def arguments():
|
|||
install.add_argument("--cipher", help="cryptsetup cipher used to"
|
||||
" encrypt the rootfs, eg. aes-xts-plain64")
|
||||
install.add_argument("--iter-time", help="cryptsetup iteration time (in"
|
||||
" miliseconds) to use when encrypting the system"
|
||||
" partiton")
|
||||
" milliseconds) to use when encrypting the system"
|
||||
" partition")
|
||||
install.add_argument("--add", help="comma separated list of packages to be"
|
||||
" added to the rootfs (e.g. 'vim,gcc')")
|
||||
install.add_argument("--no-fde", help="do not use full disk encryption",
|
||||
|
|
|
|||
|
|
@ -32,9 +32,9 @@ def binfmt_info(args, arch_qemu):
|
|||
for line in handle:
|
||||
if line.startswith('#') or "=" not in line:
|
||||
continue
|
||||
splitted = line.split("=")
|
||||
key = splitted[0].strip()
|
||||
value = splitted[1]
|
||||
split = line.split("=")
|
||||
key = split[0].strip()
|
||||
value = split[1]
|
||||
full[key] = value[1:-2]
|
||||
|
||||
ret = {}
|
||||
|
|
|
|||
|
|
@ -111,7 +111,7 @@ def test_foreground_pipe(args):
|
|||
|
||||
# Check if all child processes are killed after timeout.
|
||||
# The first command uses ps to get its process group id (pgid) and echo it
|
||||
# to stdout. All of the test commmands will be running under that pgid.
|
||||
# to stdout. All of the test commands will be running under that pgid.
|
||||
cmd = ["sudo", "sh", "-c",
|
||||
"pgid=$(ps -p ${1:-$$} -o pgid=);echo $pgid | tr -d '\n';" +
|
||||
"sleep 10 | sleep 20 | sleep 30"]
|
||||
|
|
|
|||
|
|
@ -310,7 +310,7 @@ package() {
|
|||
|
||||
ln -s gcc "$pkgdir"/usr/bin/cc
|
||||
|
||||
# we dont support gcj -static
|
||||
# we don't support gcj -static
|
||||
# and saving 35MB is not bad.
|
||||
find "$pkgdir" -name libgtkpeer.a \
|
||||
-o -name libgjsmalsa.a -o \
|
||||
|
|
|
|||
|
|
@ -329,7 +329,7 @@ package() {
|
|||
|
||||
ln -s gcc "$pkgdir"/usr/bin/cc
|
||||
|
||||
# we dont support gcj -static
|
||||
# we don't support gcj -static
|
||||
# and saving 35MB is not bad.
|
||||
find "$pkgdir" -name libgtkpeer.a \
|
||||
-o -name libgjsmalsa.a -o \
|
||||
|
|
|
|||
Loading…
Reference in New Issue