From 3fd22104a84f01414718d96fbb70717cee34e510 Mon Sep 17 00:00:00 2001 From: Oliver Smith Date: Fri, 11 Nov 2022 08:23:53 +0100 Subject: [PATCH] pmb ci: error on using --all with script names You can either say you want all scripts, or give a list of script names, not both. Add it this way and not with an add_mutually_exclusive_group, as I'll add a add_mutually_exclusive_group in the next patch to only specify --all or --fast, but having --fast with script names is fine. Reviewed-by: Luca Weiss Link: https://lists.sr.ht/~postmarketos/pmbootstrap-devel/%3C20221111072354.3431-2-ollieparanoid@postmarketos.org%3E --- pmb/helpers/frontend.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pmb/helpers/frontend.py b/pmb/helpers/frontend.py index abb8961d..3a7c0b4a 100644 --- a/pmb/helpers/frontend.py +++ b/pmb/helpers/frontend.py @@ -643,6 +643,9 @@ def ci(args): scripts_selected = {} if args.scripts: + if args.all: + raise RuntimeError("Combining --all with script names doesn't" + " make sense") for script in args.scripts: if script not in scripts_available: logging.error(f"ERROR: script '{script}' not found in git"