From 0aa1dd71454444754e25a5f0124be8481ea063b6 Mon Sep 17 00:00:00 2001 From: Oliver Smith Date: Sun, 24 May 2020 08:32:48 +0200 Subject: [PATCH] pmb.parse.deviceinfo.sanity_check: verify chassis (MR 1933) --- pmb/parse/deviceinfo.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/pmb/parse/deviceinfo.py b/pmb/parse/deviceinfo.py index bfad92f2..8296ffdd 100644 --- a/pmb/parse/deviceinfo.py +++ b/pmb/parse/deviceinfo.py @@ -50,6 +50,20 @@ def sanity_check(info, path): raise RuntimeError("Please add 'deviceinfo_codename=\"" + codename + "\"' to: " + path) + # "chassis" is required + chassis_types = pmb.config.deviceinfo_chassis_types + if "chassis" not in info or not info["chassis"]: + logging.info("NOTE: the most commonly used chassis types in" + " postmarketOS are 'handset' (for phones) and 'tablet'.") + raise RuntimeError(f"Please add 'deviceinfo_chassis' to: {path}") + + # "chassis" validation + chassis_type = info["chassis"] + if chassis_type not in chassis_types: + raise RuntimeError(f"Unknown chassis type '{chassis_type}', should" + f" be one of {', '.join(chassis_types)}. Fix this" + f" and try again: {path}") + def deviceinfo(args, device=None): """