From 05675321d6ebb5c784cb65594c375170706c0c48 Mon Sep 17 00:00:00 2001 From: Oliver Smith Date: Sun, 26 Mar 2023 18:49:32 +0200 Subject: [PATCH] pmb.parse.arguments: don't use python 3.9 feature Replace action=argparse.BooleanOptionalAction with action="store_true" so it still works with Python 3.8 and 3.7. These aren't EOL yet, and unless we have a good reason to drop support for them, we can still support them. The purpose of vermin ("pmbootstrap ci vermin") would be to warn about this, filed a bug that it didn't catch it: https://github.com/netromdk/vermin/issues/168 Reviewed-by: Luca Weiss Link: https://lists.sr.ht/~postmarketos/pmbootstrap-devel/%3C20230326164931.2390-1-ollieparanoid@postmarketos.org%3E --- pmb/parse/arguments.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pmb/parse/arguments.py b/pmb/parse/arguments.py index 128758c0..86e0003b 100644 --- a/pmb/parse/arguments.py +++ b/pmb/parse/arguments.py @@ -366,7 +366,7 @@ def arguments_qemu(subparser): ret.add_argument("--host-qemu", dest="host_qemu", action='store_true', help="Use the host system's qemu") - ret.add_argument("--efi", action=argparse.BooleanOptionalAction, + ret.add_argument("--efi", action="store_true", help="Use EFI boot (default: direct kernel image boot)") return ret