2017-05-26 20:08:45 +00:00
|
|
|
"""
|
2018-01-04 03:53:35 +00:00
|
|
|
Copyright 2018 Oliver Smith
|
2017-05-26 20:08:45 +00:00
|
|
|
|
|
|
|
This file is part of pmbootstrap.
|
|
|
|
|
|
|
|
pmbootstrap is free software: you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
pmbootstrap is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with pmbootstrap. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
"""
|
2017-08-07 22:53:54 +00:00
|
|
|
import os
|
|
|
|
import logging
|
2017-05-26 20:08:45 +00:00
|
|
|
import pmb.config
|
2018-01-18 22:05:27 +00:00
|
|
|
import pmb.parse.version
|
2017-05-26 20:08:45 +00:00
|
|
|
|
|
|
|
|
|
|
|
def replace_variables(apkbuild):
|
|
|
|
"""
|
|
|
|
Replace a hardcoded list of variables inside the APKBUILD.
|
|
|
|
"""
|
|
|
|
ret = apkbuild
|
|
|
|
# _flavor: ${_device} (lineageos kernel packages)
|
|
|
|
ret["_flavor"] = ret["_flavor"].replace("${_device}",
|
|
|
|
ret["_device"])
|
|
|
|
|
|
|
|
# pkgname: $_flavor
|
|
|
|
ret["pkgname"] = ret["pkgname"].replace("${_flavor}", ret["_flavor"])
|
|
|
|
|
|
|
|
# subpackages: $pkgname
|
|
|
|
replaced = []
|
|
|
|
for subpackage in ret["subpackages"]:
|
|
|
|
replaced.append(subpackage.replace("$pkgname", ret["pkgname"]))
|
|
|
|
ret["subpackages"] = replaced
|
|
|
|
|
2017-06-05 01:58:45 +00:00
|
|
|
# makedepends: $makedepends_host, $makedepends_build, $_llvmver
|
2017-05-26 20:08:45 +00:00
|
|
|
replaced = []
|
|
|
|
for makedepend in ret["makedepends"]:
|
|
|
|
if makedepend.startswith("$"):
|
|
|
|
key = makedepend[1:]
|
|
|
|
if key in ret:
|
|
|
|
replaced += ret[key]
|
|
|
|
else:
|
|
|
|
raise RuntimeError("Could not resolve variable " +
|
|
|
|
makedepend + " in APKBUILD of " +
|
|
|
|
apkbuild["pkgname"])
|
|
|
|
else:
|
|
|
|
# replace in the middle of the string
|
|
|
|
for var in ["_llvmver"]:
|
|
|
|
makedepend = makedepend.replace("$" + var, ret[var])
|
|
|
|
replaced += [makedepend]
|
2017-07-22 09:54:49 +00:00
|
|
|
|
|
|
|
# Python: ${pkgname#py-}
|
|
|
|
if ret["pkgname"].startswith("py-"):
|
|
|
|
replacement = ret["pkgname"][3:]
|
|
|
|
for var in ["depends", "makedepends", "subpackages"]:
|
|
|
|
for i in range(len(ret[var])):
|
|
|
|
ret[var][i] = ret[var][i].replace(
|
|
|
|
"${pkgname#py-}", replacement)
|
|
|
|
|
2017-05-26 20:08:45 +00:00
|
|
|
ret["makedepends"] = replaced
|
|
|
|
return ret
|
|
|
|
|
|
|
|
|
|
|
|
def cut_off_function_names(apkbuild):
|
|
|
|
"""
|
|
|
|
For subpackages: only keep the subpackage name, without the internal
|
|
|
|
function name, that tells how to build the subpackage.
|
|
|
|
"""
|
|
|
|
sub = apkbuild["subpackages"]
|
|
|
|
for i in range(len(sub)):
|
|
|
|
sub[i] = sub[i].split(":", 1)[0]
|
|
|
|
apkbuild["subpackages"] = sub
|
|
|
|
return apkbuild
|
|
|
|
|
|
|
|
|
2018-01-18 22:05:27 +00:00
|
|
|
def apkbuild(args, path, check_pkgver=True):
|
2017-05-26 20:08:45 +00:00
|
|
|
"""
|
|
|
|
Parse relevant information out of the APKBUILD file. This is not meant
|
|
|
|
to be perfect and catch every edge case (for that, a full shell parser
|
|
|
|
would be necessary!). Instead, it should just work with the use-cases
|
|
|
|
covered by pmbootstrap and not take too long.
|
|
|
|
|
2018-01-18 22:05:27 +00:00
|
|
|
:param path: full path to the APKBUILD
|
|
|
|
:param version_check: verify that the pkgver is valid.
|
|
|
|
:returns: relevant variables from the APKBUILD. Arrays get returned as
|
|
|
|
arrays.
|
2017-05-26 20:08:45 +00:00
|
|
|
"""
|
Properly rebuild/install packages when something changed (Fix #120, #108, #131) (#129)
TLDR: Always rebuild/install packages when something changed when executing "pmbootstrap install/initfs/flash", more speed in dependency resolution.
---
pmbootstrap has already gotten some support for "timestamp based rebuilds", which modifies the logic for when packages should be rebuilt. It doesn't only consider packages outdated with old pkgver/pkgrel combinations, but also packages, where a source file has a newer timestamp, than the built package has.
I've found out, that this can lead to more rebuilds than expected. For example, when you check out the pmbootstrap git repository again into another folder, although you have already built packages. Then all files have the timestamp of the checkout, and the packages will appear to be outdated. While this is not largely a concern now, this will become a problem once we have a binary package repository, because then the packages from the binary repo will always seem to be outdated, if you just freshly checked out the repository.
To combat this, git gets asked if the files from the aport we're looking at are in sync with upstream, or not. Only when the files are not in sync with upstream and the timestamps of the sources are newer, a rebuild gets triggered from now on.
In case this logic should fail, I've added an option during "pmbootstrap init" where you can enable or disable the "timestamp based rebuilds" option.
In addition to that, this commit also works on fixing #120: packages do not get updated in "pmbootstrap install" after they have been rebuilt. For this to work, we specify all packages explicitly for abuild, instead of letting abuild do the resolving. This feature will also work with the "timestamp based rebuilds".
This commit also fixes the working_dir argument in pmb.helpers.run.user, which was simply ignored before.
Finally, the performance of the dependency resolution is faster again (when compared to the current version in master), because the parsed apkbuilds and finding the aport by pkgname gets cached during one pmbootstrap call (in args.cache, which also makes it easy to put fake data there in testcases).
The new dependency resolution code can output lots of verbose messages for debugging by specifying the `-v` parameter. The meaning of that changed, it used to output the file names where log messages come from, but no one seemed to use that anyway.
2017-07-10 15:23:43 +00:00
|
|
|
# Try to get a cached result first (we assume, that the aports don't change
|
|
|
|
# in one pmbootstrap call)
|
|
|
|
if path in args.cache["apkbuild"]:
|
|
|
|
return args.cache["apkbuild"][path]
|
|
|
|
|
2017-11-04 16:12:33 +00:00
|
|
|
# Read the file and check line endings
|
2017-05-26 20:08:45 +00:00
|
|
|
with open(path, encoding="utf-8") as handle:
|
|
|
|
lines = handle.readlines()
|
2017-11-04 16:12:33 +00:00
|
|
|
if handle.newlines != '\n':
|
|
|
|
raise RuntimeError("Wrong line endings in APKBUILD: " + path)
|
2017-05-26 20:08:45 +00:00
|
|
|
|
|
|
|
# Parse all attributes from the config
|
|
|
|
ret = {}
|
|
|
|
for i in range(len(lines)):
|
|
|
|
for attribute, options in pmb.config.apkbuild_attributes.items():
|
|
|
|
if not lines[i].startswith(attribute + "="):
|
|
|
|
continue
|
|
|
|
|
|
|
|
# Extend the line value until we reach the ending quote sign
|
|
|
|
line_value = lines[i][len(attribute + "="):-1]
|
|
|
|
end_char = None
|
|
|
|
if line_value.startswith("\""):
|
|
|
|
end_char = "\""
|
|
|
|
value = ""
|
2017-08-19 01:15:28 +00:00
|
|
|
first_line = i
|
2017-05-26 20:08:45 +00:00
|
|
|
while i < len(lines) - 1:
|
|
|
|
value += line_value.replace("\"", "").strip()
|
2017-08-19 01:15:28 +00:00
|
|
|
if not end_char:
|
2017-05-26 20:08:45 +00:00
|
|
|
break
|
2017-08-19 01:15:28 +00:00
|
|
|
elif line_value.endswith(end_char):
|
|
|
|
# This check is needed to allow line break directly after opening quote
|
|
|
|
if i != first_line or line_value.count(end_char) > 1:
|
|
|
|
break
|
2017-05-26 20:08:45 +00:00
|
|
|
value += " "
|
|
|
|
i += 1
|
|
|
|
line_value = lines[i][:-1]
|
|
|
|
|
|
|
|
# Split up arrays, delete empty strings inside the list
|
|
|
|
if options["array"]:
|
|
|
|
if value:
|
|
|
|
value = list(filter(None, value.split(" ")))
|
|
|
|
else:
|
|
|
|
value = []
|
|
|
|
ret[attribute] = value
|
|
|
|
|
2017-08-08 13:03:17 +00:00
|
|
|
# Add missing keys
|
2017-05-26 20:08:45 +00:00
|
|
|
for attribute, options in pmb.config.apkbuild_attributes.items():
|
|
|
|
if attribute not in ret:
|
|
|
|
if options["array"]:
|
|
|
|
ret[attribute] = []
|
|
|
|
else:
|
|
|
|
ret[attribute] = ""
|
|
|
|
|
2017-08-08 13:03:17 +00:00
|
|
|
# Properly format values
|
|
|
|
ret = replace_variables(ret)
|
|
|
|
ret = cut_off_function_names(ret)
|
|
|
|
|
2017-08-07 22:53:54 +00:00
|
|
|
# Sanity check: pkgname
|
|
|
|
suffix = "/" + ret["pkgname"] + "/APKBUILD"
|
|
|
|
if not os.path.realpath(path).endswith(suffix):
|
|
|
|
logging.info("Folder: '" + os.path.dirname(path) + "'")
|
|
|
|
logging.info("Pkgname: '" + ret["pkgname"] + "'")
|
|
|
|
raise RuntimeError("The pkgname must be equal to the name of"
|
|
|
|
" the folder, that contains the APKBUILD!")
|
|
|
|
|
2017-11-28 19:12:16 +00:00
|
|
|
# Sanity check: arch
|
|
|
|
if not len(ret["arch"]):
|
|
|
|
raise RuntimeError("Arch must not be empty: " + path)
|
|
|
|
|
2018-01-18 22:05:27 +00:00
|
|
|
# Sanity check: pkgver
|
|
|
|
if check_pkgver:
|
|
|
|
if "-r" in ret["pkgver"] or not pmb.parse.version.validate(ret["pkgver"]):
|
|
|
|
logging.info("NOTE: Valid pkgvers are described here:")
|
|
|
|
logging.info("<https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#pkgver>")
|
|
|
|
raise RuntimeError("Invalid pkgver '" + ret["pkgver"] +
|
|
|
|
"' in APKBUILD: " + path)
|
|
|
|
|
2017-08-07 22:53:54 +00:00
|
|
|
# Fill cache
|
Properly rebuild/install packages when something changed (Fix #120, #108, #131) (#129)
TLDR: Always rebuild/install packages when something changed when executing "pmbootstrap install/initfs/flash", more speed in dependency resolution.
---
pmbootstrap has already gotten some support for "timestamp based rebuilds", which modifies the logic for when packages should be rebuilt. It doesn't only consider packages outdated with old pkgver/pkgrel combinations, but also packages, where a source file has a newer timestamp, than the built package has.
I've found out, that this can lead to more rebuilds than expected. For example, when you check out the pmbootstrap git repository again into another folder, although you have already built packages. Then all files have the timestamp of the checkout, and the packages will appear to be outdated. While this is not largely a concern now, this will become a problem once we have a binary package repository, because then the packages from the binary repo will always seem to be outdated, if you just freshly checked out the repository.
To combat this, git gets asked if the files from the aport we're looking at are in sync with upstream, or not. Only when the files are not in sync with upstream and the timestamps of the sources are newer, a rebuild gets triggered from now on.
In case this logic should fail, I've added an option during "pmbootstrap init" where you can enable or disable the "timestamp based rebuilds" option.
In addition to that, this commit also works on fixing #120: packages do not get updated in "pmbootstrap install" after they have been rebuilt. For this to work, we specify all packages explicitly for abuild, instead of letting abuild do the resolving. This feature will also work with the "timestamp based rebuilds".
This commit also fixes the working_dir argument in pmb.helpers.run.user, which was simply ignored before.
Finally, the performance of the dependency resolution is faster again (when compared to the current version in master), because the parsed apkbuilds and finding the aport by pkgname gets cached during one pmbootstrap call (in args.cache, which also makes it easy to put fake data there in testcases).
The new dependency resolution code can output lots of verbose messages for debugging by specifying the `-v` parameter. The meaning of that changed, it used to output the file names where log messages come from, but no one seemed to use that anyway.
2017-07-10 15:23:43 +00:00
|
|
|
args.cache["apkbuild"][path] = ret
|
2017-05-26 20:08:45 +00:00
|
|
|
return ret
|
2018-02-24 21:49:10 +00:00
|
|
|
|
|
|
|
|
|
|
|
def subpkgdesc(path, function):
|
|
|
|
"""
|
|
|
|
Get the pkgdesc of a subpackage in an APKBUILD.
|
|
|
|
|
|
|
|
:param path: to the APKBUILD file
|
|
|
|
:param function: name of the subpackage (e.g. "nonfree_userland")
|
|
|
|
:returns: the subpackage's pkgdesc
|
|
|
|
"""
|
|
|
|
# Read all lines
|
|
|
|
with open(path, encoding="utf-8") as handle:
|
|
|
|
lines = handle.readlines()
|
|
|
|
|
|
|
|
# Prefixes
|
|
|
|
prefix_function = function + "() {"
|
|
|
|
prefix_pkgdesc = "\tpkgdesc=\""
|
|
|
|
|
|
|
|
# Find the pkgdesc
|
|
|
|
in_function = False
|
|
|
|
for line in lines:
|
|
|
|
if in_function:
|
|
|
|
if line.startswith(prefix_pkgdesc):
|
|
|
|
return line[len(prefix_pkgdesc):-2]
|
|
|
|
elif line.startswith(prefix_function):
|
|
|
|
in_function = True
|
|
|
|
|
|
|
|
# Failure
|
|
|
|
if not in_function:
|
|
|
|
raise RuntimeError("Could not find subpackage function, no line starts"
|
|
|
|
" with '" + prefix_function + "' in " + path)
|
|
|
|
raise RuntimeError("Could not find pkgdesc of subpackage function '" +
|
|
|
|
function + "' (spaces used instead of tabs?) in " +
|
|
|
|
path)
|