syndicate-lang
/
syndicate-protocols
1
0
Fork 1
Code Issues 3 Pull Requests 2 Projects Releases Wiki Activity

protocol: Sync peer should be #!any #8

New Issue
Closed
opened 2024-01-13 16:28:59 +00:00 by ehmry · 1 comment
ehmry commented 2024-01-13 16:28:59 +00:00
Contributor
Copy Link

The protocol schema should not specify #!#f for the Sync peer because the module does not set an embeddedType which implies that the this field should really be an embedded literal #f.

97876335ba/schemas/protocol.prs (L19)

- Sync = <sync @peer #!#f>.
+ Sync = <sync @peer #!any>.

I would make a PR but I cannot build the schema tool to compile the bundle and my reimplementation doesn't fully replicate the schema parser.

The protocol schema should not specify `#!#f` for the `Sync` peer because the module does not set an `embeddedType` which implies that the this field should really be an embedded literal `#f`. https://git.syndicate-lang.org/syndicate-lang/syndicate-protocols/src/commit/97876335ba8d37575e17481be6bdc40a1bd4959d/schemas/protocol.prs#L19 ```diff - Sync = <sync @peer #!#f>. + Sync = <sync @peer #!any>. ``` I would make a PR but I cannot build the schema tool to compile the bundle and my reimplementation doesn't fully replicate the schema parser.
ehmry commented 2024-01-14 10:19:21 +00:00
Author
Contributor
Copy Link

After reading the fine text of preserves-schema I've decided that the schema is correct and I am generating the wrong code.

After reading the fine text of [preserves-schema](https://preserves.dev/preserves-schema.html) I've decided that the schema is correct and I am generating the wrong code.
ehmry closed this issue 2024-01-14 10:19:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
0.4.0-r20240301
0.3.0-r20231031
0.2.0-r20231018
0.1.1-r20230211
0.1.0-r20230210
0.0.4-r20230207
0.0.3-r20230204
0.0.2-r20220206
0.0.1-r20220114
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: syndicate-lang/syndicate-protocols#8
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?