From 7f07be80dfa35613b0189a81bf3b861dc999d6cf Mon Sep 17 00:00:00 2001
From: Tony Garnock-Jones <tonyg@leastfixedpoint.com>
Date: Tue, 28 May 2019 16:54:58 +0100
Subject: [PATCH] Improve OverlayLink publication

---
 packages/server/src/disco.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/server/src/disco.js b/packages/server/src/disco.js
index eaca2b6..2af2ba0 100644
--- a/packages/server/src/disco.js
+++ b/packages/server/src/disco.js
@@ -35,6 +35,7 @@ const fs = require('fs');
 spawn named 'peerAdvertisement' {
   const localId = RandomID.randomId(8, false);
   assert OverlayNode(localId);
+  console.log('Local node ID is', localId);
 
   during Federation.ManagementScope($managementScope) {
     during P.Envelope(managementScope, Overlay($overlayId, _)) {
@@ -135,10 +136,10 @@ spawn named 'uplinkSelection' {
           this.peers.forEach((p) => { if (better(p)) best = p; });
           if (best && (best.get(1) !== localId)) {
             this.bestAddr = best.get(3);
-            this.bestPeer = best;
+            this.bestPeer = OverlayNode(best.get(1));
           } else {
             this.bestAddr = rootAddr;
-            this.bestPeer = null;
+            this.bestPeer = OverlayRoot();
           }
         }
 
@@ -149,8 +150,7 @@ spawn named 'uplinkSelection' {
         assert P.Proposal(managementScope, Federation.Uplink(overlayId, this.bestAddr, overlayId))
           when (this.bestAddr);
 
-        assert P.Proposal(overlayId, OverlayLink(OverlayNode(localId),
-                                                 this.bestPeer || OverlayRoot()))
+        assert P.Proposal(overlayId, OverlayLink(OverlayNode(localId), this.bestPeer))
           when (this.bestAddr);
       }
     }