From e2575c3ea1acc79953790b382a4196b9de5d8fc0 Mon Sep 17 00:00:00 2001 From: Tony Garnock-Jones Date: Sun, 7 Aug 2016 11:31:51 -0400 Subject: [PATCH] Remove observablePropertyCounter to help avoid accumulating garbage on prop redefinition --- js/src/dataflow.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/js/src/dataflow.js b/js/src/dataflow.js index aef7165..4088408 100644 --- a/js/src/dataflow.js +++ b/js/src/dataflow.js @@ -10,7 +10,6 @@ function Graph() { this.damagedNodes = Immutable.Set(); this.currentSubjectId = null; this.enforceSubjectPresence = true; - this.observablePropertyCounter = 0; } Graph.prototype.withSubject = function (subjectId, f) { @@ -81,7 +80,7 @@ Graph.prototype.repairDamage = function (repairNode) { Graph.prototype.defineObservableProperty = function (obj, prop, value, maybeOptions) { var graph = this; var options = typeof maybeOptions === 'undefined' ? {} : maybeOptions; - var objectId = '__' + (options.baseId || prop) + '_' + (graph.observablePropertyCounter++); + var objectId = '__' + (options.baseId || prop); Object.defineProperty(obj, prop, { configurable: true, enumerable: true,