From 8276a50552de3d6d56c2a47694c6270549c0da75 Mon Sep 17 00:00:00 2001 From: Tony Garnock-Jones Date: Tue, 31 Oct 2023 13:27:03 +0100 Subject: [PATCH] Repair error in Rust integer width calculation --- implementations/python/tests/samples.bin | Bin 12436 -> 12629 bytes implementations/python/tests/samples.pr | 2 ++ .../preserves/preserves/tests/samples.pr | 2 ++ .../rust/preserves/src/value/packed/writer.rs | 2 +- tests/samples.bin | Bin 12436 -> 12629 bytes tests/samples.pr | 2 ++ 6 files changed, 7 insertions(+), 1 deletion(-) diff --git a/implementations/python/tests/samples.bin b/implementations/python/tests/samples.bin index dbb41bf694a41c0e886b7b8d17639655d431ff03..d6008aaab2fa3445f5efce4545e376e67137ad9e 100644 GIT binary patch delta 204 zcmbP|cr|ImB!l|RI+=MTmKNq_rY6Qlh6V&!TQ;+Vq!yQK64@ZcsAP95Q2XxWjz80G zW@Q>4_^OLdtYxz<(0pB-#=4-}ie$sTy9ZU*T~W#@XU%^> delta 10 RcmcbbG$nDvBm<_F762S!1gQW3 diff --git a/implementations/python/tests/samples.pr b/implementations/python/tests/samples.pr index df8ae0b..a390467 100644 --- a/implementations/python/tests/samples.pr +++ b/implementations/python/tests/samples.pr @@ -118,6 +118,7 @@ float14: @"+qNaN" float15: @"-qNaN" float16: @"-qNaN" + int-98765432109876543210987654321098765432109: int-12345678123456781234567812345678: int-1234567812345678123456781234567: int-257: @@ -151,6 +152,7 @@ int1234567812345678123456781234567: int12345678123456781234567812345678: int87112285931760246646623899502532662132736: + int98765432109876543210987654321098765432109: list0: list4: list4a: diff --git a/implementations/racket/preserves/preserves/tests/samples.pr b/implementations/racket/preserves/preserves/tests/samples.pr index df8ae0b..a390467 100644 --- a/implementations/racket/preserves/preserves/tests/samples.pr +++ b/implementations/racket/preserves/preserves/tests/samples.pr @@ -118,6 +118,7 @@ float14: @"+qNaN" float15: @"-qNaN" float16: @"-qNaN" + int-98765432109876543210987654321098765432109: int-12345678123456781234567812345678: int-1234567812345678123456781234567: int-257: @@ -151,6 +152,7 @@ int1234567812345678123456781234567: int12345678123456781234567812345678: int87112285931760246646623899502532662132736: + int98765432109876543210987654321098765432109: list0: list4: list4a: diff --git a/implementations/rust/preserves/src/value/packed/writer.rs b/implementations/rust/preserves/src/value/packed/writer.rs index 72d6294..0fad0b2 100644 --- a/implementations/rust/preserves/src/value/packed/writer.rs +++ b/implementations/rust/preserves/src/value/packed/writer.rs @@ -289,7 +289,7 @@ impl Writer for BinaryOrderWriter { macro_rules! fits_in_bytes { ($v:ident, $limit:literal) => {{ let bits = $limit * 8 - 1; - $v >= -(2 << bits) && $v < (2 << bits) + $v >= -(1 << bits) && $v < (1 << bits) }}; } diff --git a/tests/samples.bin b/tests/samples.bin index dbb41bf694a41c0e886b7b8d17639655d431ff03..d6008aaab2fa3445f5efce4545e376e67137ad9e 100644 GIT binary patch delta 204 zcmbP|cr|ImB!l|RI+=MTmKNq_rY6Qlh6V&!TQ;+Vq!yQK64@ZcsAP95Q2XxWjz80G zW@Q>4_^OLdtYxz<(0pB-#=4-}ie$sTy9ZU*T~W#@XU%^> delta 10 RcmcbbG$nDvBm<_F762S!1gQW3 diff --git a/tests/samples.pr b/tests/samples.pr index df8ae0b..a390467 100644 --- a/tests/samples.pr +++ b/tests/samples.pr @@ -118,6 +118,7 @@ float14: @"+qNaN" float15: @"-qNaN" float16: @"-qNaN" + int-98765432109876543210987654321098765432109: int-12345678123456781234567812345678: int-1234567812345678123456781234567: int-257: @@ -151,6 +152,7 @@ int1234567812345678123456781234567: int12345678123456781234567812345678: int87112285931760246646623899502532662132736: + int98765432109876543210987654321098765432109: list0: list4: list4a: